[PATCH] D77442: [SVE] Take constant fold fast path for splatted vscale vectors
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 9 06:52:52 PDT 2020
spatel added a comment.
In D77442#2027808 <https://reviews.llvm.org/D77442#2027808>, @ctetreau wrote:
> By the way, this test case was generated via a script. Should I commit the script also? If so, where should I put it?
Not sure if you mean the test code itself or the assertion for the tests? llvm/utils/ is probably the spot to find/add scripts that help with testing.
================
Comment at: llvm/test/Analysis/ConstantFolding/cmp-vec-fast-path.ll:7
+
+; RUN: opt -instcombine -S < %s | FileCheck %s
+
----------------
This should be handled more specifically with "-constprop" (don't need the full power of -instcombine).
Use the standard "utils/update_test_checks.py" to auto-generate the CHECK lines? Can also pre-commit the baseline tests, then update here so we just have diffs for the assertion lines.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77442/new/
https://reviews.llvm.org/D77442
More information about the llvm-commits
mailing list