[PATCH] D78961: [WIP][FileCollector] Add doc comments

Jan Korous via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 17:13:31 PDT 2020


jkorous marked 3 inline comments as done.
jkorous added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCollector.h:84
+  /// The directory where collected files are copied to in copyFiles().
+  const std::string StorageDir;
 
----------------
JDevlieghere wrote:
> I'm not a fan of this rename, for two reasons:
> 
>  - It is the root of where files are copied.
>  - It is the root of the RedirectingFileSystem. 
Reverted this part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78961/new/

https://reviews.llvm.org/D78961





More information about the llvm-commits mailing list