[PATCH] D75670: [FPEnv] Intrinsic llvm.roundeven

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1416
   case Intrinsic::strip_invariant_group:
+  case Intrinsic::roundeven:
   case Intrinsic::masked_load:
----------------
This should probably be with ceil/floor/trunc etc. further down?


================
Comment at: llvm/lib/Analysis/ConstantFolding.cpp:1504
   case Intrinsic::experimental_constrained_round:
   case Intrinsic::experimental_constrained_trunc:
   case Intrinsic::experimental_constrained_nearbyint:
----------------
should constrained_roundeven be here?


================
Comment at: llvm/test/Transforms/InstCombine/double-float-shrink-2.ll:84
+  %D = fpext float %C to double
+  ; --> roundf
+  %E = call double @roundeven(double %D)
----------------
This comment should be roundevenf


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75670/new/

https://reviews.llvm.org/D75670