[PATCH] D79127: [XCOFF][AIX] Emit correct alignment for csect
Jason Liu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 8 13:26:08 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-readonly-with-relocation.ll:8
;CHECK: .comm a[RW],4,2
-;CHECK-NEXT: .csect .data[RW]
+;CHECK-NEXT: .csect .data[RW], 2
;CHECK-NEXT: .globl b
----------------
hubert.reinterpretcast wrote:
> Should the style be consistent between `.csect` and `.comm` over the use of spaces after the comma?
I agree the style should be consistent for the use of spaces after comma.
It seems like for clang, we would have a space after comma (at least for instructions). So looks like .csect directive is following that convention.
We could have a NFC patch later to clean it up for .comm.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79127/new/
https://reviews.llvm.org/D79127
More information about the llvm-commits
mailing list