[PATCH] D79597: [asan_symbolize] Fix bug handling C++ symbols when using Atos.

[Julian Lettner via Phabricator via llvm-commits]

yln added a comment.

LGTM with suggested update for the comment.  Thanks!

> I'm guessing the idea here was to try to drop any listed arguments for the function being symbolized.

If you are able to find out why this was done quickly (in a few minutes), then please document the reason here in this review thread.



================
Comment at: compiler-rt/lib/asan/scripts/asan_symbolize.py:281
+    #   * If `foo` is a C++ function atos emits parentheses argument types.
+    #   * `foo` may contain templates which may contain parentheses.
     match = re.match('^(.*) \(in (.*)\) \((.*:\d*)\)$', atos_line)
----------------
```
* For C functions atos omits parentheses and argument types.
* For C++ functions the function name (i.e., `foo` above) may contain templates which may contain parentheses.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79597/new/

https://reviews.llvm.org/D79597