[PATCH] D79517: [MLIR] Rename SideEffects.td -> SideEffectInterfaces.td

[Jacques Pienaar via Phabricator via llvm-commits]

jpienaar accepted this revision.
jpienaar added a comment.
This revision is now accepted and ready to land.

In D79517#2026204 <https://reviews.llvm.org/D79517#2026204>, @stephenneuendorffer wrote:

> @jpienaar Thoughts?  You have a blocking review.


My preference would be same as Mehdi (don't repeat interfaces if already in the name/path). And we could make this consistent by renaming all of the others ones instead (and moving dialect ones). This is smaller changes that makes these consistent and if we then follow up with larger restructuring to make them all consistent and can remove the redundancy in the naming SGTM (we've had this argument before and I know some consider path as part of identifier and some don't - so my view of redundancy is not necessarily uniform).

Given this makes it consistent with the generated tblgen outputs too, this seems like easier start that gets us to consistent state for NFC moves later. So agree with @ftynse and @herhut that this maintains the current naming of the others and makes it more consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79517/new/

https://reviews.llvm.org/D79517