[PATCH] D70379: [AMDGPU] Reserving VGPR for future SGPR Spill

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 08:33:10 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:10867-10868
+      !Info->isEntryFunction()) {
+    int FI =
+        MFI.CreateStackObject(4, 4, false, nullptr, TargetStackID::SGPRSpill);
+    Info->reserveVGPRforSGPRSpills(MF, FI);
----------------
Don't need the dummy stack object anymore


================
Comment at: llvm/lib/Target/AMDGPU/SIMachineFunctionInfo.cpp:349
+bool SIMachineFunctionInfo::reserveVGPRforSGPRSpills(MachineFunction &MF,
+                                                     int FI) {
+  const GCNSubtarget &ST = MF.getSubtarget<GCNSubtarget>();
----------------
The FI argument is unused


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70379/new/

https://reviews.llvm.org/D70379





More information about the llvm-commits mailing list