[PATCH] D79609: [GlobalISel] Don't add duplicate successors to MBBs when translating indirectbr
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 8 08:33:10 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:842
MachineBasicBlock &CurBB = MIRBuilder.getMBB();
- for (const BasicBlock *Succ : successors(&BrInst))
+ for (const BasicBlock *Succ : successors(&BrInst)) {
+ // It's legal for indirectbr instructions to have duplicate blocks in the
----------------
I believe isSuccessor is a linear scan. This should use a pointer set like SelectionDAGBuilder
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79609/new/
https://reviews.llvm.org/D79609
More information about the llvm-commits
mailing list