[PATCH] D78106: [CSInfo][NFC] Interpret loaded parameter value separately

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 06:56:39 PDT 2020


djtodoro added a comment.

Some nits included.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:647
 
-  // There is no information for the call instruction.
-  if (CallFwdRegsInfo == CalleesMap.end())
-    return;
-
-  auto *MBB = CallMI->getParent();
+  auto *MF = CurMI->getMF();
+  const DIExpression *EmptyExpr =
----------------
`MachineFunction *MF`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:743
+                                      ParamSet &Params) {
+  auto *MF = CallMI->getMF();
+  auto CalleesMap = MF->getCallSitesInfo();
----------------
`MachineFunction *MF`


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:751
+
+  auto *MBB = CallMI->getParent();
+
----------------
`MachineBasicBlock *MBB`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78106/new/

https://reviews.llvm.org/D78106





More information about the llvm-commits mailing list