[PATCH] D79616: [NFC][DwarfDebug] Avoid default capturing when using lambdas

[David Stenberg via Phabricator via llvm-commits]

dstenb accepted this revision.
dstenb added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:710
+  auto getForwardingRegsDefinedByMI =
+      [&ForwardedRegWorklist, &TRI](const MachineInstr &MI,
+                                    SmallSetVector<unsigned, 4> &Defs) {
----------------
djtodoro wrote:
> dstenb wrote:
> > Perhaps `ForwardedRegWorklist` even should be passed as a parameter? That could further show the intent of the function.
> Makes sense to me, thanks!
Oh, and as `TRI` is a pointer maybe the reference should not be used here? Perhaps we should change the auto references to pointers at line 655-657 to stress that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79616/new/

https://reviews.llvm.org/D79616