[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

[Sourabh Singh Tomar via Phabricator via llvm-commits]

SouraVX updated this revision to Diff 262825.
SouraVX added a comment.

Addressed @ikudrin comments, Thanks for this!

- Simplified the public interface further, as per suggestion. Now `parseMacro` and `parseMacinfo` is the public interfacing of parsing macro and macinfo respectively.
- For the case of `strp` or `strx` forms found in `macinfo[.dwo]` section, halt parsing(default behavior since these forms are invalid WRT debug_macinfo[.dwo] sections.)
- Corrected the unit length in test case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736

Files:
  llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h
  llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
  llvm/lib/DebugInfo/DWARF/DWARFDebugMacro.cpp
  llvm/test/DebugInfo/X86/debug-macinfo-strp.s
  llvm/test/DebugInfo/X86/debug-macinfo-strx.s
  llvm/test/DebugInfo/X86/debug-macro-empty-macro-offset.s
  llvm/test/DebugInfo/X86/debug-macro-empty-str-offset.s
  llvm/test/DebugInfo/X86/debug-macro-multi-cu-strx.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D78736.262825.patch
Type: text/x-patch
Size: 17053 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200508/7718fadc/attachment-0001.bin>