[PATCH] D79616: [NFC][DwarfDebug] Avoid default capturing when using lambdas

David Stenberg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 01:01:51 PDT 2020


dstenb added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:710
+  auto getForwardingRegsDefinedByMI =
+      [&ForwardedRegWorklist, &TRI](const MachineInstr &MI,
+                                    SmallSetVector<unsigned, 4> &Defs) {
----------------
Perhaps `ForwardedRegWorklist` even should be passed as a parameter? That could further show the intent of the function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79616/new/

https://reviews.llvm.org/D79616





More information about the llvm-commits mailing list