[PATCH] D79605: MachineBasicBlock::updateTerminator now requires an explicit layout successor.

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

> (such as invoke, and potentially in the future, callbr).

Is the endgame here that we relax the restriction that updateTerminator() requires an analyzable branch?



================
Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:522
+  /// block layout which may have been made. PreviousLayoutSuccessor should be
+  /// set to the block which may have been used as fallback before the block
+  /// layout was modified.  If the block previously fell through to that block,
----------------
fallthrough.


================
Comment at: llvm/lib/CodeGen/TailDuplicator.cpp:955
+    if (ShouldUpdateTerminators)
+      PrevBB->updateTerminator(TailBB->getNextNode());
+
----------------
Is this related to the rest of the patch?  I don't see any obvious interaction.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79605/new/

https://reviews.llvm.org/D79605