[PATCH] D79239: getMainExecutable: Fix hand-rolled AT_EXECPATH search for older branches

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 15:14:22 PDT 2020


MaskRay added a comment.

We are using git now. Please use `git commit --amend --author=`

Thanks for stripping unneeded Phabricator tags.

I usually do this when committing: `arcfilter; git fetch origin master && git rebase origin/master; last-minute-testing && git push origin HEAD:master` where `arcfilter` is a shell function which drops unneeded Phabricator tags (`Subscribers:`, `Summary:`, `Tags:`, `Reviewers:`) but keeps `Differential Revision:` and `Reviewed By:`

  arcfilter () {
          arc amend
          git log -1 --pretty=%B | awk '/Reviewers:|Subscribers:/{p=1} /Reviewed By:|Differential Revision:/{p=0} !p && !/^Summary:$/ {sub(/^Summary: /,"");print}' | git commit --amend -F -
  }

Also, we don't use `Signed-off-by: `


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79239/new/

https://reviews.llvm.org/D79239





More information about the llvm-commits mailing list