[PATCH] D78623: [flang] Semantic checks for SELECT RANK

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 13:02:09 PDT 2020


DavidTruby added inline comments.


================
Comment at: flang/lib/Semantics/resolve-names.cpp:5111
+    MakePlaceholder(*name, MiscDetails::Kind::SelectRankAssociateName);
+    association.name = &*name;
+  }
----------------
klausler wrote:
> DavidTruby wrote:
> > Why does this need de-referencing and then referencing again?
> Because it's not a pointer.
No.. and neither is the thing it is being assigned to? I don't understand how it not being a pointer is relevant.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78623/new/

https://reviews.llvm.org/D78623





More information about the llvm-commits mailing list