[PATCH] D79590: [lld] Add a new output section ".text.unknown" for funtions with unknown hotness info especially in sampleFDO

[Wei Mi via Phabricator via llvm-commits]

wmi marked 2 inline comments as done.
wmi added a comment.

Thanks for looking at it.



================
Comment at: lld/ELF/Writer.cpp:131
+  // ".text.unknown" means the hotness of the section is unknown. When
+  // SampleFDO is used, if function doesn't have sample, it could be very
+  // cold or it could be new function never being sampled. Those functions
----------------
MaskRay wrote:
> a function
Fixed.


================
Comment at: lld/ELF/Writer.cpp:132
+  // SampleFDO is used, if function doesn't have sample, it could be very
+  // cold or it could be new function never being sampled. Those functions
+  // will be kept in the ".text.unknown" section.
----------------
MaskRay wrote:
> a new function
Fixed.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79590/new/

https://reviews.llvm.org/D79590