[PATCH] D79580: AMDGPU: Don't assert on unknown address spaces

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added a comment.

In D79580#2025725 <https://reviews.llvm.org/D79580#2025725>, @arsenm wrote:

> In D79580#2025685 <https://reviews.llvm.org/D79580#2025685>, @rampitec wrote:
>
> > How do we get these address spaces? I'd rather error out.
>
>
> You can use __attribute__((address_space)) or hand write IR. We should not error on valid IR. Someday a frontend may wish to track special information with a custom address space number, which we can handle as a global alias similar to how x86 accepts any arbitrary address space


It sounds dangerous. An unknown address space has unknown semantics. How could we assume anything about it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79580/new/

https://reviews.llvm.org/D79580