[PATCH] D79552: [YAMLVFSWriter][Tests][NFC] Add couple tests

[Jan Korous via Phabricator via llvm-commits]

jkorous marked an inline comment as done.
jkorous added inline comments.


================
Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:2278
+
+TEST_F(VFSFromYAMLTest, YAMLVFSWriterTestEmbeddedDirs) {
+  ScopedDir TestDirectory("virtual-file-system-test", /*Unique*/ true);
----------------
JDevlieghere wrote:
> What's an "embedded dir"? I'm not sure what makes this test different from the existing writer test. Could you add a small comment about what the test is testing?
You're right, "nested" is probably a better word here.
This originally helped me to understand how the implementation handles empty directories and since position in the mapping mattered I wanted to have a clean, isolated "unit"-test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79552/new/

https://reviews.llvm.org/D79552