[PATCH] D79551: [YAMLVFSWriter] Fix directory handling
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 10:47:17 PDT 2020
JDevlieghere added a comment.
Herald added a subscriber: ormris.
Small nit but otherwise this LGTM. Thanks for fixing this!
================
Comment at: llvm/unittests/Support/VirtualFileSystemTest.cpp:2244
+ ScopedDir TestDirectory("virtual-file-system-test", /*Unique*/ true);
+ ScopedDir TheFirstEntry(TestDirectory + "/thefirstentry");
+ ScopedDir AnotherEntry(TestDirectory + "/anotherentry");
----------------
I don't have a really strong opinion about this, but I think it'd be nice to be consistent with the other tests and use `a`, `b` and `c`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79551/new/
https://reviews.llvm.org/D79551
More information about the llvm-commits
mailing list