[PATCH] D79462: [WebAssembly] MC: Fix for data aliases with offsets (getelementptr)
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 10:47:12 PDT 2020
aheejin accepted this revision.
aheejin added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/test/MC/WebAssembly/offset.s:12
+
+.set sym_b, sym_a + 4
+
----------------
sbc100 wrote:
> aheejin wrote:
> > Does this handle something like
> > ```
> > .set sym_c, 16
> > ```
> > too? The code assumes there always exists a base symbol.
> Yes, you are right it looks like we don't support absolute addresses like this yet. If its OK with you I'll leave that as a followup change? We might need a different symbol flag for that because currently all our data symbols need to be relative to a segment,.
Yeah sounds good.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79462/new/
https://reviews.llvm.org/D79462
More information about the llvm-commits
mailing list