[PATCH] D78014: [AssumeBundles] Prevent generation of some redundant assumes

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. See the two comments below



================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:180
+          return RK;
   }
   return RetainedKnowledge::none();
----------------
jdoerfert wrote:
> Nit: `if (!Bundle) continue` to reduce indention or `if (... Bundle = ...)`
?


================
Comment at: llvm/lib/Analysis/AssumeBundleQueries.cpp:171
     return RetainedKnowledge::none();
   }
   for (auto &U : V->uses()) {
----------------
We should later also look at the value itself. It is a position that can take attributes it might have one attached.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78014/new/

https://reviews.llvm.org/D78014