[PATCH] D79462: [WebAssembly] MC: Fix for data aliases with offsets (getelementptr)

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/aliases.ll:2
+; Based llvm/test/CodeGen/X86/aliases.ll
+; RUN: llc < %s -mtriple=wasm32-unknown-uknown -asm-verbose=false | FileCheck %s
+
----------------
Can we also check if `llvm-mc` can correctly parse the result of this test? That will possibly break the current codebase.


================
Comment at: llvm/test/MC/WebAssembly/offset.s:12
+
+.set sym_b, sym_a + 4
+
----------------
Does this handle something like
```
.set sym_c, 16
```
too? The code assumes there always exists a base symbol.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79462/new/

https://reviews.llvm.org/D79462