[PATCH] D79517: [MLIR] Rename SideEffects.td -> SideEffectInterfaces.td

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer added a comment.

In D79517#2024521 <https://reviews.llvm.org/D79517#2024521>, @ftynse wrote:

> In D79517#2023685 <https://reviews.llvm.org/D79517#2023685>, @stephenneuendorffer wrote:
>
> > The dialect interfaces don't necessary exist in an "Interfaces" path.   (Although perhaps they should?)
>
>
> I would differentiate between dialect-specific interfaces (e.g., LinalgStructured) and dialect-independent. The former should live with their dialect similarly to other dialect-specific stuff.


I agree...  I think pertaining to the comment from @mehdi_amini , if dialect dependent interfaces always live in Dialect/Foo/Interfaces, then they don't need to include "Interfaces" in the name.

> Regarding this change, I am always for consistency and since it makes the code base more consistent, I support the change even if we decide to mass-rename everything later.

Good point here...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79517/new/

https://reviews.llvm.org/D79517