[PATCH] D79452: [VectorCombine] scalarize binop of inserted elements into vector constants

Thu May 7 07:54:13 PDT 2020

spatel added a comment.

In D79452#2024909 <https://reviews.llvm.org/D79452#2024909>, @RKSimon wrote:

> In D79452#2022567 <https://reviews.llvm.org/D79452#2022567>, @spatel wrote:
>
> > I was assuming that we don't have the same concern about vector code as the scalar code here, but we could use ConstantFolding to generate the result for each element of the output vector.
>
>
> Inserting into a binop(undef, undef) constant fold makes sense as a safer option.

Ok - we can generalize the base vector constant matching then. I'll add some tests and update the code.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79452/new/

https://reviews.llvm.org/D79452