[PATCH] D79429: [mlir] Add missing dependency to MLIRMlirOptMain
Lei Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 7 07:20:05 PDT 2020
antiagainst added a comment.
In D79429#2021563 <https://reviews.llvm.org/D79429#2021563>, @stephenneuendorffer wrote:
> We saw some broken windows builds this morning, but I think there is a better fix. In general, I don't think everything should depend on intrinsics_gen.. In this case, MLIROptMain was missing a PUBLIC dependence on it's libraries (including Linalg) which was (I believe) the root of the problem.
Thanks for the pointer! Yeah that's better. Sent https://reviews.llvm.org/D79574 to remove the redundancy DEPENDS.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79429/new/
https://reviews.llvm.org/D79429
More information about the llvm-commits
mailing list