[PATCH] D79527: Correctly modify the CFG in IfConverter, and then remove the CorrectExtraCFGEdges function.

[James Y Knight via Phabricator via llvm-commits]

jyknight added inline comments.


================
Comment at: llvm/lib/CodeGen/IfConversion.cpp:2292
       continue;
+    }
 
----------------
efriedma wrote:
> I think this contradicts the documentation for this function?  "This will leave FromBB as an empty block, so remove all of its successor edges except for the fall-through edge."  Maybe this is better, but please make it consistent.
Fixed the doc, thanks. Keeping the existing fallthrough successor didn't really make any sense as this function moves the block to the end of the function.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79527/new/

https://reviews.llvm.org/D79527