[PATCH] D79329: [MLIR] Update the FunctionAndBlockSignatureConverter and NonVoidToVoidReturnOpConverter of Buffer Assignment

[Stephan Herhut via Phabricator via llvm-commits]

herhut requested changes to this revision.
herhut added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: stephenneuendorffer.


================
Comment at: mlir/lib/Transforms/BufferPlacement.cpp:423
+    // should be appended to the function arguments list for this result.
+    // Otherwise, it is remained as the function result type.
+    if (convertedType.isa<MemRefType>())
----------------
`it is remained` -> `it remains unchanged as a function result`?


================
Comment at: mlir/test/Transforms/buffer-placement-prepration.mlir:34
+// CHECK-SAME: (i1, f16)
+//      CHECK: linalg.copy(%[[ARG2]], %[[RESULT]])
+//      CHECK: return %[[ARG0]], %[[ARG1]]
----------------
If this returned a memref before, why would it not return a memref now? We should only rewrite the return values that got rewritten from `tensor` to `memref`. Not the ones that already were a `memref`. I'd assume those would be left alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79329/new/

https://reviews.llvm.org/D79329