[PATCH] D79513: [dsymutil] Print statistics about debug_info reduction in verbose mode.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 03:55:09 PDT 2020


avl added a comment.

Probably, it makes sense to not put printing code into DWARFLinker? i.e. add callbacks to DwarfFile:

class DwarfFile {
...

  std::function <(StringRef FileName, StringRef TableName, uint64_t TableFinalSize)> StatisticsCallback;

};

or to add callback to DWARFlinker:

  /// Report statistics.
  void setStatisticCallback ( std::function <(StringRef FileName, StringRef TableName, uint64_t TableFinalSize)> StatisticsCallback );

So, that DWARFlinker reports statistics, but analyzing and displaying would be done separately. 
In this case in dsymutil`s DwarfLinkerForBinary.cpp. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79513/new/

https://reviews.llvm.org/D79513





More information about the llvm-commits mailing list