[PATCH] D79481: [AMDGPU] Cluster shader exports

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.exp.ll:552-558
+define amdgpu_kernel void @test_export_clustering(float %x, float %y) #0 {
+  %z0 = fadd float %x, %y
+  call void @llvm.amdgcn.exp.f32(i32 32, i32 15, float %x, float %y, float %z0, float 0.0, i1 false, i1 false)
+  %z1 = fsub float %y, %x
+  call void @llvm.amdgcn.exp.f32(i32 33, i32 15, float %x, float %y, float %z1, float 1.0, i1 true, i1 false)
+  ret void
+}
----------------
foad wrote:
> critson wrote:
> > foad wrote:
> > > Can you pre-commit this? Did it actually have a waitcnt before this fix?
> > Sorry for the effort, but can you educate me on the concept of pre-committing the test.  It will fail without the rest of the code in this patch as a waitcnt is inserted at present.
> I mean, commit @test_export_clustering but with check lines that show the current codegen. (This is easier if you auto-generate the check lines. I hadn't noticed that you wrote these ones by hand.) Then, when you rebase the current patch, it will show us exactly what effect it had on the codegen for this function.
> 
> It's not essential but it is helpful to reviewers.
Nice!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79481/new/

https://reviews.llvm.org/D79481