[PATCH] D79037: [StructurizeCFG] Fix region nodes ordering

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 01:41:38 PDT 2020


sameerds added a comment.

In D79037#2022995 <https://reviews.llvm.org/D79037#2022995>, @ekatz wrote:

> In D79037#2022768 <https://reviews.llvm.org/D79037#2022768>, @sameerds wrote:
>
> > I see. It sure does look like PR25378. Then the only thing left is one new test with two sibling loops. The intention is to cover the case where CurrentLoop is not the parent of L.
>
>
> I don't think it is possible, although I might be wrong.
>  Because the way I see it, for loop A be interfered with another loop B, while POT, there must be at least one block that belongs to loop A that is dependent on at least one block in loop B. But then loop B must be finished before loop A, and actually inside it. Otherwise, it won't be recognized as a separate loop.
>
> I hope I explained it clear enough. Otherwise, can you please give an example?


I agree. That means that if L exists, then CurrentLoop must be its parent, right? So instead of checking for this condition, the code will have to assert it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79037/new/

https://reviews.llvm.org/D79037





More information about the llvm-commits mailing list