[PATCH] D76786: [ARM][MVE] Add support for incrementing gathers

[Dave Green via Phabricator via llvm-commits]

dmgreen accepted this revision.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks. I think in hindsight this might have been a couple of patches, we we managed to power through.

LGTM with one minor alteration



================
Comment at: llvm/lib/Target/ARM/MVEGatherScatterLowering.cpp:514
+  // Merge the add into the gather, if it is the only user
+  if (cast<Instruction>(Offsets)->getNumUses() == 1)
+    return cast<IntrinsicInst>(
----------------
I think that in this case we needn't check for one use of Offsets. Because we are only folding it into the instruction, not altering it in any way, it should always be OK I think. And smaller. But, er, check that makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76786/new/

https://reviews.llvm.org/D76786