[PATCH] D78424: [flang] Added Semantic Checks for 2 Data constraints and fixed the semantic errors in 3 test cases
Anchu Rajendran S via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 23:15:52 PDT 2020
anchu-rajendran added a comment.
@klausler , Thank you for the review comments! I have made the suggested changes.
================
Comment at: flang/lib/Semantics/tools.cpp:733
+bool IsAutomaticArray(const Symbol &symbol) {
+ if (symbol.IsObjectArray()) {
----------------
klausler wrote:
> This code would return `true` for an explicit-shape dummy argument array with non-constant bounds, yes? Such objects are not "automatic". I think that you need a better name for this predicate.
Thank You! I have changed the implementation according to the description of automatic data objects given in 3.11
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78424/new/
https://reviews.llvm.org/D78424
More information about the llvm-commits
mailing list