[PATCH] D79211: [lld-macho] Support pc-relative section relocations

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 21:01:38 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/InputSection.cpp:46
+      // in terms of the addresses in the input file. Here we adjust it so that
+      // it describes the offset from the start of the relocated section.
+      // TODO: Figure out what to do for non-pcrel section relocations.
----------------
smeenai wrote:
> Perhaps "the relocated target section", to make it completely clear which section is being referred to?
good point. I think I'll just say "target section", once it's an offset it's irrelevant whether the section has been relocated


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79211/new/

https://reviews.llvm.org/D79211





More information about the llvm-commits mailing list