[PATCH] D79542: [WebAssembly] Disallow 'shared-mem' rather than 'atomics'

[Sam Clegg via Phabricator via llvm-commits]

sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lld/test/wasm/shared-memory-no-atomics.yaml:60
 
-# SHARED: 'atomics' feature is disallowed by {{.*}}shared-memory-no-atomics.yaml.tmp1.o, so --shared-memory must not be used{{$}}
+# SHARED: shared memory is disallowed by {{.*}}shared-memory-no-atomics.yaml.tmp1.o because it was not compiled with 'atomics' or 'bulk-memory' features, so --shared-memory must not be used.
----------------
This sentence sounds a little redundant to me?  The part about shared memory not being allowed.  Maybe its just me ..


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:265
+  // This pseudo-feature tells the linker whether shared memory would be safe
+  EmitFeature("shared-mem");
 
----------------
Why not add this to WebAssemblyFeatureKV?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79542/new/

https://reviews.llvm.org/D79542