[PATCH] D79527: Correctly modify the CFG in IfConverter, and then remove the CorrectExtraCFGEdges function.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 17:04:25 PDT 2020


efriedma added inline comments.


================
Comment at: llvm/lib/CodeGen/IfConversion.cpp:2292
       continue;
+    }
 
----------------
I think this contradicts the documentation for this function?  "This will leave FromBB as an empty block, so remove all of its successor edges except for the fall-through edge."  Maybe this is better, but please make it consistent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79527/new/

https://reviews.llvm.org/D79527





More information about the llvm-commits mailing list