[PATCH] D62540: [SampleFDO] For functions without profiles, provide an option to put them in a special text section

[Wei Mi via Phabricator via llvm-commits]

wmi marked an inline comment as done.
wmi added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:181
+static cl::opt<bool> ProfileUnknownInSpecialSection(
+    "profile-unknown-in-special-section", cl::Hidden, cl::init(false),
+    cl::ZeroOrMore,
----------------
davidxl wrote:
> wenlei wrote:
> > Set the default to true here so `partial-profile` alone can enable all related tweaks? 
> This should default to be true  since the partial profile is also used as a guard -- but perhaps as a follow up after more testing.
Yes, that is the plan. We need some extra work in linker and in runtime to make the unknown section work as we expect, and we need to make sure even if there is no support in runtime, the special section should behave just like .text section. Before that is done and tested, we want to keep it off by default. 


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62540/new/

https://reviews.llvm.org/D62540