[PATCH] D79359: OpenMPOpt Remarks Support

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:288
+            auto newLoc = &*F.getEntryBlock().getFirstInsertionPt();
+            return OR << "OpenMP runtime call " << RFI.Name << " moved to "
+                      << ore::NV("OpenMPRuntimeMoves", newLoc->getDebugLoc());
----------------
Why doesn't RFI.Name have a ore::NV field name. Tools might certainly be interested in what functions are being optimized.


================
Comment at: llvm/lib/Transforms/IPO/OpenMPOpt.cpp:321
+      auto Remark = [&](OptimizationRemark OR) {
+        return OR << "OpenMP runtime call " << RFI.Name << " deduplicated";
+      };
----------------
Same here: a NV for RFI.Name seems useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79359/new/

https://reviews.llvm.org/D79359