[PATCH] D79514: [flang] Response to Steve Scalpone's suggestion to improve a message

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 14:44:37 PDT 2020


PeteSteinfeld reopened this revision.
PeteSteinfeld marked an inline comment as done.
PeteSteinfeld added inline comments.
This revision is now accepted and ready to land.


================
Comment at: flang/lib/Evaluate/check-expression.cpp:210
         specExprContext_ == SpecificationExprContext::BOUND) { // C750
-      return "reference to variable '"s + symbol.name().ToString() +
-          "' not allowed for derived type components";
+      return "derived type component not allowed to reference to variable '"s +
+          symbol.name().ToString() + "'";
----------------
kiranchandramohan wrote:
> is there an extra "to"? Like should the message be "not allowed to reference variable"?
Ay yi yi!  Thanks for catching this.  I'll fix it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79514/new/

https://reviews.llvm.org/D79514





More information about the llvm-commits mailing list