[PATCH] D79513: [dsymutil] Print statistics about debug_info reduction in verbose mode.
Jonas Devlieghere via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 14:09:32 PDT 2020
JDevlieghere marked 3 inline comments as done.
JDevlieghere added inline comments.
================
Comment at: llvm/lib/DWARFLinker/DWARFLinker.cpp:2533
+ if (Options.Verbose) {
+ // Create a vector sorted in descending order by output size.
----------------
friss wrote:
> JDevlieghere wrote:
> > friss wrote:
> > > Should we be using a different `--stat` flag for this? The verbose flag will output so much info on a real link...
> > Not to mention that verbose mode implies single threaded, which is the reason I put it under verbose. If we want to use `--stats` we'll need a way to synchronize the printing across architectures for fat binaries. Do you think that's worth it?
> Do we need to synchronize? Maybe we should just print the current architecture at the beginning of the line to disambiguate?
We do, the output is all intertwined otherwise. I actually implemented the `--stats` thing you suggested before moving it under verbose for exactly this reason.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79513/new/
https://reviews.llvm.org/D79513
More information about the llvm-commits
mailing list