[PATCH] D79484: [DebugInfo] Fortran module DebugInfo support in LLVM

Sourabh Singh Tomar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 14:09:18 PDT 2020


SouraVX marked 7 inline comments as done.
SouraVX added inline comments.


================
Comment at: llvm/lib/IR/LLVMContextImpl.h:849
+    return hash_combine(Scope, Name, ConfigurationMacros, IncludePath, File,
+                        LineNo);
   }
----------------
aprantl wrote:
> How likely is it going to be that you have two fortran modules with the same name but a different, file or lineno? Is it necessary for performance to hash the file/line?
Thanks for pointing this out! This seems like an unlikely situation, therefore removed it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79484/new/

https://reviews.llvm.org/D79484





More information about the llvm-commits mailing list