[PATCH] D78929: [AIX][XCOFF]emit extern linkage for the llvm intrinsic symbol
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 13:01:37 PDT 2020
DiggerLin marked 3 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:5294
+ auto &Context = DAG.getMachineFunction().getMMI().getContext();
+ const MCSymbolXCOFF *Sym = cast<MCSymbolXCOFF>(
+ Context.getOrCreateSymbol(Twine(".") + Twine(SymName)));
----------------
sfertile wrote:
> Why not leave the name as is, and prepend the '.' when we create/lookup the symbol in the AsmPrinter?
if leave name as is, the branch will be
bl memset
not
bl .memset
if leave name as is , we want to generate bl .memset . we need to modify the operand(ExternalSymbol) of branch to generate correct bl .memset
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78929/new/
https://reviews.llvm.org/D78929
More information about the llvm-commits
mailing list