[PATCH] D77523: Add CanonicalizeFreezeInLoops pass

Wed May 6 13:01:17 PDT 2020

aqjune added a comment.

I applied this patch on e124e83 <https://reviews.llvm.org/rGe124e83db688128eacfc7f3a1262fef6cc59b971>, and ran SPEC2017rate. Here is the result (unit: sec.):

  		e124e83	+D77523	speedup
  500.perlbench_r	844.24	830.61	1.64%
  502.gcc_r	488.62	487.73	0.18%
  505.mcf_r	673.73	678.61	-0.72%
  520.omnetpp_r	684.97	684.75	0.03%
  523.xalancbmk_r	753.45	750.64	0.37%
  525.x264_r	598.98	597.80	0.20%
  531.deepsjeng_r	481.23	481.94	-0.15%
  541.leela_r	774.59	775.01	-0.05%
  557.xz_r	694.84	696.73	-0.27%
  508.namd_r	621.90	622.51	-0.10%
  511.povray_r	967.31	966.13	0.12%
  519.lbm_r	671.68	671.86	-0.03%
  538.imagick_r	1122.32	1134.04	-1.03%
  544.nab_r	943.58	943.61	0.00%

A few tests that raised an error because it required fortran are excluded.
(1) I chose e124e83 <https://reviews.llvm.org/rGe124e83db688128eacfc7f3a1262fef6cc59b971> because it was the commit where xalancbmk_r showed the small slowdown. With this patch only, xalancbmk_r is okay.
(2) mcf_r shows slowdown with this patch, but on my machine the speedup of the (full) patch was visible only on SPEC compiled with LLVM testsuite.
Interestingly again, with this patch only, its speedup (of the testsuite's mcf_r) is larger than expected (compared with e124e83 <https://reviews.llvm.org/rGe124e83db688128eacfc7f3a1262fef6cc59b971>, it is 3.4%)
(3) 538.imagick_r has 1% slowdown, which seems to be within error - these numbers are medians after 3 runs, and the baseline of 538.imagick_r fluctuates between around 1122 and 1133 (+D77523 <https://reviews.llvm.org/D77523>: 1133 ~ 1138).
(4) 500.perlbench_r has 1.6% speedup, and the speedup is consistent (it did not fluctuate).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77523/new/

https://reviews.llvm.org/D77523