[PATCH] D79463: [mlir] Add NamedAttrList
River Riddle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 11:52:47 PDT 2020
rriddle added inline comments.
================
Comment at: mlir/lib/IR/MLIRContext.cpp:751
+ MLIRContext *context) {
+ if (value.empty())
+ return context->getImpl().emptyDictionaryAttr;
----------------
We could just have a private `DictionaryAttr::getEmpty(MLIRContext *context)` that the other methods call. That would allow for moving the other part of this back to Attributes.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79463/new/
https://reviews.llvm.org/D79463
More information about the llvm-commits
mailing list