[PATCH] D75866: [AIX] supporting the visibility attribute for aix assembly
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 6 10:13:38 PDT 2020
hubert.reinterpretcast added inline comments.
================
Comment at: llvm/lib/MC/MCAsmStreamer.cpp:833
+ default:
+ break;
+ case MCSA_Hidden:
----------------
DiggerLin wrote:
> hubert.reinterpretcast wrote:
> > This should be the case for `MCSA_Invalid`, but for other values, we should call `llvm_unreachable` indicating that we got an unexpected value for `Visibility`.
> I do not think the MCSA_Invalid will come to here. if come to the function. it should be llvm_unreachable too.
`PPCAIXAsmPrinter::emitLinkage` uses `MCSA_Invalid` for `GlobalValue::DefaultVisibility`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75866/new/
https://reviews.llvm.org/D75866
More information about the llvm-commits
mailing list