[PATCH] D79476: [AMDGPU] Don't implement GCNHazardRecognizer::PreEmitNoops(SUnit *)

[Jay Foad via Phabricator via llvm-commits]

foad marked 2 inline comments as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNHazardRecognizer.cpp:232
-unsigned GCNHazardRecognizer::PreEmitNoops(SUnit *SU) {
-  IsHazardRecognizerMode = false;
-  return PreEmitNoopsCommon(SU->getInstr());
----------------
rampitec wrote:
> Do we still need this variable? I am not sure, it is initialized as false, but is there an alive path after this change?
Yes I think we still need this to select different behaviour in getWaitStatesSince. For the post-RA scheduler usage, the variable just defaults to false. For standalone usage, PreEmitNoops sets it to true. I am still working on further cleanups in this area.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79476/new/

https://reviews.llvm.org/D79476