[PATCH] D79467: [PDB] Optimize public symbol processing

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

Can you diff the full output of `microsoft-pdb\cvdump\cvdump.exe your_exe.pdb` and `llvm-pdbutil dump -all your_exe.pdb` before and after this patch? (with any large exe). This can be a bit tedious because the text dump is very large, but you can at least validate that things are still right (you're probably already doing this).



================
Comment at: llvm/lib/DebugInfo/PDB/Native/GSIStreamBuilder.cpp:207
+  // algorithm used here corredsponds to the function
+  // caseInsensitiveComparePchPchCchCch in the reference implementation.
+  auto BucketCmp = [](const BulkPublic &L, const BulkPublic &R) {
----------------
Maybe provide a link to the reference implemention repo? (ie.https://github.com/microsoft/microsoft-pdb)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79467/new/

https://reviews.llvm.org/D79467