[PATCH] D76869: [Clang] Restore replace_path_prefix instead of startswith

Sylvain Audi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 6 09:07:27 PDT 2020


saudi added a comment.

In D76869#2022784 <https://reviews.llvm.org/D76869#2022784>, @amccarth wrote:

> LGTM.  Thanks.
>
> I'm less worried about the details of style (like camel casing), since I have the impression things are changing.  In general, stick to prevalent style of the file when it's discernable.  My issue with PrefixStyle was that the name could be confusing.


Thanks!
@MaskRay, are you ok with this patch? I think it needs your approval, as it doesn't show as "Ready to land".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76869/new/

https://reviews.llvm.org/D76869





More information about the llvm-commits mailing list