[PATCH] D79410: [MLIR] [OpenMP] Add basic OpenMP parallel operation

Wed May 6 08:35:34 PDT 2020

DavidTruby marked an inline comment as done.
DavidTruby added inline comments.
Herald added a subscriber: stephenneuendorffer.

================
Comment at: mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td:60
+def ClauseDefaultShared : StrEnumAttrCase<"defshared">;
+def ClauseDefaultNone : StrEnumAttrCase<"defnone">;
+
----------------
kiranchandramohan wrote:
> DavidTruby wrote:
> > jdoerfert wrote:
> > > If the preprocessor runs on this file you can use the OMPKinds.def macros to avoid listing stuff explicitly here. That also keeps everything in sync.
> > I'll be honest, I have absolutely no idea how tablegen works. Will the preprocessor be run on files generated by this? I assume it will but I don't really know....
> I am guessing it will run on this file because of the presence of include and #define at the top of this file (lines 14-17).
I tried this and it seems like tablegen tries to interpret `#define` and then shouts at me. Any ideas how I can get it to ignore my #define and just put it in the generated code?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79410/new/

https://reviews.llvm.org/D79410