[PATCH] D79467: [PDB] Optimize public symbol processing

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

This looks good as far as I can tell. Is there good test coverage here, e.g. if there's an off-by-one somewhere, would it be caught?



================
Comment at: lld/COFF/PDB.cpp:1708
   pdb.addNamedStreams();
+  pdb.addPublicsToPDB();
 
----------------
Before it ran at the end of addObjectsToPDB(). Does the order matter?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79467/new/

https://reviews.llvm.org/D79467