[PATCH] D79468: [mlir][Linalg] Start a LinalgToStandard pass and move conversion to library calls.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked 4 inline comments as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp:352
 
-template <typename LinalgOp>
-static SmallVector<Type, 4> ExtractOperandTypes(Operation *op) {
----------------
bondhugula wrote:
> Can LinAlgToLLVM now be completely removed? Do you still need anything in it? I couldn't immediately tell from the commit summary and this diff. 
Not yet, I'm doing it in a staged fashion but the endgoal is indeed to remove it.


================
Comment at: mlir/test/mlir-cpu-runner/linalg_integration_test.mlir:1
-// RUN: mlir-opt %s -convert-linalg-to-llvm \
+// RUN: mlir-opt %s -convert-linalg-to-std -convert-linalg-to-llvm \
 // RUN: | mlir-cpu-runner -e dot -entry-point-result=f32 -shared-libs=%linalg_test_lib_dir/libmlir_test_cblas%shlibext,%linalg_test_lib_dir/libmlir_test_cblas_interface%shlibext \
----------------
bondhugula wrote:
> I see you still have all those reshape/slice/transpose being converted directly from linalg to llvm instead of via std.view/subview. 
Yes for now this is still the case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79468/new/

https://reviews.llvm.org/D79468